fix: mobile Safari notification and keyboard navigation tests#183
Merged
JesperDramsch merged 1 commit intomainfrom Jan 5, 2026
Merged
fix: mobile Safari notification and keyboard navigation tests#183JesperDramsch merged 1 commit intomainfrom
JesperDramsch merged 1 commit intomainfrom
Conversation
- Add 'Notification' in window check before accessing Notification.permission to prevent ReferenceError on mobile Safari where Web Notifications API is not supported - Skip keyboard navigation test on mobile browsers since Tab key navigation is not a primary input method on touch-based devices Fixes mobile-safari test failures for: - notification-system.spec.js action bar notifications test - search-functionality.spec.js keyboard navigation test (flaky)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mobile-safari test failures for: